Adds minimal model contract enforcement for glue adapter #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
menuetb
approved these changes
Dec 14, 2023
aajisaka
added a commit
to aajisaka/dbt-glue
that referenced
this pull request
Jan 23, 2024
…-samples#297)" This reverts commit 4192346.
4 tasks
aajisaka
added a commit
to aajisaka/dbt-glue
that referenced
this pull request
Jan 23, 2024
…-samples#297)" This reverts commit 4192346.
aajisaka
added a commit
to aajisaka/dbt-glue
that referenced
this pull request
Jan 23, 2024
…-samples#297)" This reverts commit 4192346.
4 tasks
moomindani
pushed a commit
that referenced
this pull request
Jan 24, 2024
* Revert "Bump black from 23.11.0 to 23.12.0 (#303)" This reverts commit ee2aa88. * Revert "Update versions" This reverts commit f6a377e. * Revert "Adds minimal model contract enforcement for glue adapter (#297)" This reverts commit 4192346. * Revert "Fix wrong role create db#285 (#286)" This reverts commit 1416de8. * Revert "Glue session: enable users to fix their glue_session_id name and re-use it (#301)" This reverts commit d2d31f1. * Revert "Revert "Update versions"" This reverts commit 2b5e656. * Revert "Revert "Bump black from 23.11.0 to 23.12.0 (#303)"" This reverts commit 9a2b094. * Update CHANGELOG
moomindani
pushed a commit
to moomindani/dbt-glue
that referenced
this pull request
Jan 25, 2024
…#297) * Updated to check for contract enforcement * Added a method correct string types for glue columns * Updated the CHANGELOG with changes * Utilize new GlueColumn class --------- Co-authored-by: Brian Nguyen <[email protected]> Co-authored-by: menuetb <[email protected]>
4 tasks
moomindani
added a commit
that referenced
this pull request
Jan 25, 2024
… re-use it (#322) * Adds minimal model contract enforcement for glue adapter (#297) * Updated to check for contract enforcement * Added a method correct string types for glue columns * Updated the CHANGELOG with changes * Utilize new GlueColumn class --------- Co-authored-by: Brian Nguyen <[email protected]> Co-authored-by: menuetb <[email protected]> * fixed bug --------- Co-authored-by: brianhtn <[email protected]> Co-authored-by: Brian Nguyen <[email protected]> Co-authored-by: menuetb <[email protected]> Co-authored-by: Vincent.PAUWELS <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #296
Description
This PR adds limited dbt model contract enforcement for the glue adapter. It adds a call to the
get_assert_columns_equivalent()macro which is used to enforce the schemas for view and table materializations.I say "limited" because it's missing a portion of the enforcements which includes but not limited to constraints and potential various Glue specific datatypes. In this PR, I only addressed the
stringtype.Checklist
CHANGELOG.mdand added information about my change to the "dbt-glue next" section.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.