Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add correct import for exceptions #440

Merged
merged 4 commits into from
Sep 12, 2024

Conversation

sanga8
Copy link
Contributor

@sanga8 sanga8 commented Sep 12, 2024

resolves #439

Description

Add exceptions import:
from dbt.adapters.exceptions.connection import FailedToConnectError from dbt_common.exceptions import ExecutableError

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt-glue next" section.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sanga8
Copy link
Contributor Author

sanga8 commented Sep 12, 2024

@moomindani Just fixed an import. I wasn't able to identify why the import wasn't done correctly, because I did not have this bug previously. Would you have any idea?

@moomindani moomindani added the enable-functional-tests This label enable functional tests label Sep 12, 2024
@moomindani moomindani self-assigned this Sep 12, 2024
@moomindani
Copy link
Collaborator

Thanks for contributing as always.
When we upgraded from dbt 1.7 to 1.8, it included some class changes, but I do not have any other idea..

@moomindani moomindani merged commit fbda8ce into aws-samples:main Sep 12, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enable-functional-tests This label enable functional tests repeat-contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: module 'dbt.exceptions' has no attribute 'FailedToConnectError'
2 participants