-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/migrate sql gen to macro #461
Feat/migrate sql gen to macro #461
Conversation
dbt/include/glue/macros/materializations/incremental/strategies.sql
Outdated
Show resolved
Hide resolved
@aiss93 Apologizes I forgot to submit my comments last week. Submitted them now. Having test_iceberg is good idea, but I think we still need to make sure that we have enough coverage in the test cases. Plz refer to my comments. |
Hi @moomindani do you have any additional comments or can we launch the functional tests ? |
Thanks for making changes based on my comments. Apologizes for delay in review. We are still reviewing the changes. It may take some time as our bandwidth is very limited this month, but let us update you. |
Sure thank you ! |
Thank you for your contribution! This patch brought huge value, we really appreciate your contribution. |
``` | ||
In both cases, the underlying catalog would be the AWS Glue Catalog, unique in your AWS Account and Region, and you would be able to work with the exact same data. Also make sure that if you change the name of the Glue Catalog Alias, you change it in all the other `--conf` where it's used: | ||
When using the default value, the following spark configruation should be added to enable iceberg. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
configuration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops thanks I did not notice. Addressed it.
resolves #457
Description
The following PR addresses the following points:
Checklist
CHANGELOG.md
and added information about my change to the "dbt-glue next" section.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.