Skip to content

Commit

Permalink
Merge pull request #142 from kuettai/main
Browse files Browse the repository at this point in the history
Enhance #141
  • Loading branch information
kuettai authored Sep 18, 2024
2 parents 7696647 + 8ff74f3 commit d89cc76
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 0 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# Custom
.DS_Store
test*
crossAccounts.json
output.zip
Expand Down
5 changes: 5 additions & 0 deletions services/efs/drivers/EfsDriver.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,3 +42,8 @@ def _checkBackupPolicy(self):

if backup['BackupPolicy']['Status'] == 'DISABLED':
self.results['AutomatedBackup'] = [-1, 'Disabled']

def _checkSingleAZ(self):
if 'AvailabilityZoneName' in self.efs:
self.results['IsSingleAZ'] = [-1, self.efs['AvailabilityZoneName']]

15 changes: 15 additions & 0 deletions services/efs/efs.reporter.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,5 +37,20 @@
"ref": [
"[EFS Backup]<https://docs.aws.amazon.com/efs/latest/ug/awsbackup.html>"
]
},
"IsSingleAZ": {
"category": "R",
"^description": "Using EFS in SingleAZ is only suitable for development workload. It offers up to 47% cost saving compare to EFS Standard storage classes. It is not resilient to the loss of the Availability Zone.",
"downtime": 1,
"slowness": 0,
"additionalCost": 1,
"criticality": "M",
"needFullTest": 1,
"shortDesc": "Recreate new Regional EFS and migrate data over",
"ref": [
"[Create EFS]<https://docs.aws.amazon.com/efs/latest/ug/creating-using-create-fs.html>",
"[Options to transfer data]<https://docs.aws.amazon.com/efs/latest/ug/transfer-data-to-efs.html>",
"[Comparison between Regional vs SingleAZ]<https://docs.aws.amazon.com/efs/latest/ug/features.html>"
]
}
}

0 comments on commit d89cc76

Please sign in to comment.