Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix instruction for building media-no-video-codecs on Maven #601

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

bjason
Copy link
Contributor

@bjason bjason commented Feb 6, 2024

ℹ️ Description

provide a summary of the changes and the related issue, relevant motivation and context

If builders try to build with media-no-video-codecs following the instruction in README, they will be getting Duplicate class error as classes of amazon-chime-sdk-media were also getting pulled in from amazon-chime-sdk dependency

Issue #, if available

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
    • README update
    • CHANGELOG update
    • guides update
  • This change requires a dependency update
    • Amazon Chime SDK Media
    • Other (update corresponding legal documents)

🧪 How Has This Been Tested?

describe the tests that you ran to verify your changes, any relevant details for your test configuration

Built with normal media module and no-video-codecs module and verified the demo app and its app size.

implementation 'software.aws.chimesdk:amazon-chime-sdk:0.19.0'
implementation 'software.aws.chimesdk:amazon-chime-sdk-media:0.19.0'
implementation 'software.aws.chimesdk:amazon-chime-sdk-media-no-video-codecs:0.19.0'
implementation ('software.aws.chimesdk:amazon-chime-sdk:0.19.0') {
    exclude module: 'amazon-chime-sdk-media'
}

Unit test coverage

  • Class coverage:
  • Line coverage:

Additional Manual Test

  • Pause and resume remote video
  • Switch local camera
  • Rotate screen back and forth

📱 Screenshots, if available

provide screenshots/video record if there's a UI change in demo app

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@bjason bjason merged commit 741d4a7 into development Feb 7, 2024
2 of 4 checks passed
@bjason bjason deleted the fix-doc-for-no-video-codecs branch February 7, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants