Skip to content

Commit

Permalink
Adds optional nameplate prop to ContentShare (#880)
Browse files Browse the repository at this point in the history
* Adds optional nameplate prop to ContentShare

* Adds docs + changelog changes

* Changes name of ContentShare nameplate in docs, fixes changelog.

---------

Co-authored-by: Trung Le <[email protected]>
  • Loading branch information
Amethystix and ltrung authored Mar 23, 2023
1 parent 5927b25 commit 7457c5a
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Removed

### Changed

- Updated `ContentShare` to have optional nameplate prop.
### Fixed
- Fix a bug where the `isVideoEnabled` is still true even when the video device is unplugged.

Expand Down
2 changes: 1 addition & 1 deletion src/components/sdk/ContentShare/ContentShare.stories.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ const App = () => {

return (
<MeetingProvider>
<ContentShare />
<ContentShare nameplate='Content share' />
<button onClick={toggleContentShare}>Toggle content share</button>
</MeetingProvider>
);
Expand Down
4 changes: 3 additions & 1 deletion src/components/sdk/ContentShare/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@ import { useContentShareState } from '../../../providers/ContentShareProvider';
import { ContentTile } from '../../ui/ContentTile';
import { BaseSdkProps } from '../Base';

interface Props extends BaseSdkProps {}
interface Props extends BaseSdkProps {
nameplate?: string;
}

export const ContentShare: React.FC<Props> = ({ className, ...rest }) => {
const audioVideo = useAudioVideo();
Expand Down

0 comments on commit 7457c5a

Please sign in to comment.