-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate AWS SDK for JavaScript v2 APIs to v3 in demos/browser #2797
Conversation
Hey maintainers, looks like the CI is failing as the credentials are not present in secrets on my fork. |
cc active contributors @dinmin-amzn @michhyun1 |
Can someone review this PR? |
The reason is GitHub environment does not allow at the workflow level and is only at the job level https://github.com/orgs/community/discussions/14417. We have waited that feature for almost 2 year now. Due to this we currently could not be able to validate your changes against our automatic tests. Does this block you? We can copy your code to a Git clone and refer to this PR. |
No. The AWS SDK for JavaScript team is planning to announce maintenance mode in 2023, so the request will come up in future.
That would be helpful. Feel free to cherry-pick my commits in upstream branch to post a new PR. |
Close this PR in favor of #2807 |
Issue #:
From AWS SDK for JavaScript v2 README:
Description of changes:
Migrates AWS SDK for JavaScript v2 APIs to v3 in demos/browser
Testing:
CI
Checklist:
Have you successfully run
npm run build:release
locally?N/A
Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved?
No.
Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved?
No.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.