Add mem_shared to integration tests #562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added mem_shared to memory metrics list in mem_test.go - Updated agent configurations to include shared memory measurement - Ensures mem_shared metric is properly tested in integration tests
TravisStark
reviewed
Jul 28, 2025
| "mem": { | ||
| "measurement": [ | ||
| "active", "available", "available_percent", "buffered", "cached", "free", "inactive", "total", | ||
| "active", "available", "available_percent", "buffered", "cached", "free", "inactive", "shared", "total", |
Contributor
There was a problem hiding this comment.
Does this change the memory values read by the stress test? Does it affect the memory read against the thresholds.
Contributor
Author
There was a problem hiding this comment.
No, adding mem_shared to the config only collects one additional system memory metric and doesn't affect stress test thresholds, I just added the metric here for consistency since all other memory metrics were already included in these integration test configs.
sky333999
reviewed
Jul 31, 2025
| "measurement": [ | ||
| "iops_in_progress", "io_time", "reads", "read_bytes", "read_time", "writes", "write_bytes", "write_time" | ||
| ] | ||
| }, |
Contributor
There was a problem hiding this comment.
It looks like there's some mac specific tests too. Can we update those as well?
If you search for available_percent for example, it should show you the other occurrences.
sky333999
approved these changes
Aug 5, 2025
nathalapooja
approved these changes
Aug 7, 2025
sky333999
pushed a commit
that referenced
this pull request
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR incorporates the shared memory metric for integration testing.
Description of changes
mem_test.goTests
https://github.com/aws/amazon-cloudwatch-agent/actions/runs/16650544237