Skip to content

add allowlist to awsentity processor for container insights to fix service names #1683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lisguo
Copy link
Contributor

@lisguo lisguo commented May 13, 2025

Description of the issue

We added the awsentity processor to the container insights pipeline including the add_entity flag for the emfexporter.

This causes a problem where the entity processor tries to get the service name and now it overrides the EMF log's Service field which is unintended. This creates the wrong metric dimension and high cardinality metrics.

Bad: "Service": "busybox-service-jn9tc"
Good: "Service": "busybox-service"

Description of changes

Add an allow list to the awsentity processor to only allow entity attributes to be appended to the telemetry. For container insights we will only append the platform type:

"com.amazonaws.cloudwatch.entity.internal.platform.type"

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Tests

make test

Requirements

Before commit the code, please do the following steps.

  1. Run make fmt and make fmt-sh
  2. Run make lint

@lisguo lisguo changed the title add allowlist to awsentity processor for container insights [Bugfix] add allowlist to awsentity processor for container insights May 13, 2025
@lisguo lisguo changed the title [Bugfix] add allowlist to awsentity processor for container insights add allowlist to awsentity processor for container insights to fix service names May 13, 2025
Copy link
Contributor

This PR was marked stale due to lack of activity.

@github-actions github-actions bot added the Stale label May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant