Otel bump v0.115.0 -> v0.124.1 #1694
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paramadon
force-pushed
the
paramadon/otel-bump-0.124.1
branch
from
1ee5ad1 to
a6c0bb6
Compare
Paramadon
force-pushed
the
paramadon/otel-bump-0.124.1
branch
from
1c11a8b to
c019f00
Compare
Paramadon
force-pushed
the
paramadon/otel-bump-0.124.1
branch
from
c019f00 to
ca0c949
Compare
Paramadon
force-pushed
the
paramadon/otel-bump-0.124.1
branch
3 times, most recently
from
76e99a6 to
b80859b
Compare
Paramadon
force-pushed
the
paramadon/otel-bump-0.124.1
branch
from
b80859b to
a5c2769
Compare
Paramadon
commented
May 22, 2025
| } | ||
| for _, sc := range scrapeConfigs { | ||
| if sc.ScrapeFallbackProtocol == "" { | ||
| sc.ScrapeFallbackProtocol = promconfig.PrometheusText1_0_0 |
There was a problem hiding this comment.
change this to 0_0_4 to be consistent with contrib.
Paramadon
commented
May 22, 2025
| return ContextStatement{ | ||
| Context: "metric", | ||
| Statements: statements, | ||
|
|
There was a problem hiding this comment.
Add a note of why this was added/changed and why we couldn't just have added error_mode: propogate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
This pr is for bumping contrib version from v0.116.0 to 0.124.1
Description of changes
How does this change address the problem?
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Describe what tests you have done.
Requirements
Before commit the code, please do the following steps.
make fmtandmake fmt-shmake lint