[Fix] Added node_(gpu|efa|neuroncore)_request metric #1859
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aadam19
force-pushed
the
tudorman/efa-gpu-metrics
branch
from
0e5acce to
3cf5dfd
Compare
aadam19
changed the title
movence
approved these changes
Sep 12, 2025
sky333999
reviewed
Sep 12, 2025
| - node_status_condition_unknown | ||
| - node_status_capacity_pods | ||
| - node_status_allocatable_pods | ||
| - node_gpu_request |
Contributor
There was a problem hiding this comment.
Are we sure we want this? I think this was left out in the past since request & limit are always the same for GPUs.
sky333999
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues the work of my fellow noble and courageous intern @tudor-manea.
We were scraping already for the
node_(gpu|efa|neuroncore)_requestbut somehow forgot to make the agent pick it up.Link to IntegTests PR that made us realize: aws/amazon-cloudwatch-agent-test#569