Emit failure and total metrics for DPE call (#4488)

aws · Feb 5, 2025 · 388aadd · 388aadd
1 parent 0f64bd3
commit 388aadd
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/agent/vendor/github.com/aws/amazon-ecs-agent/ecs-agent/api/ecs/client/ecs_client.go b/agent/vendor/github.com/aws/amazon-ecs-agent/ecs-agent/api/ecs/client/ecs_client.go
diff --git a/agent/vendor/github.com/aws/amazon-ecs-agent/ecs-agent/metrics/constants.go b/agent/vendor/github.com/aws/amazon-ecs-agent/ecs-agent/metrics/constants.go
diff --git a/ecs-agent/api/ecs/client/ecs_client.go b/ecs-agent/api/ecs/client/ecs_client.go
@@ -763,7 +763,8 @@ func (client *ecsClient) discoverPollEndpoint(containerInstanceArn string,
 		Cluster:           aws.String(client.configAccessor.Cluster()),
 		ZoneId:            aws.String(availabilityZone),
 	})
-	client.metricsFactory.New(metrics.DiscoverPollEndpointCallName).Done(err)
+	client.metricsFactory.New(metrics.DiscoverPollEndpointFailure).Done(err)
+	client.metricsFactory.New(metrics.DiscoverPollEndpointTotal).Done(nil)
 	if err != nil {
 		// If we got an error calling the API, fallback to an expired cached endpoint if
 		// we have it.

diff --git a/ecs-agent/metrics/constants.go b/ecs-agent/metrics/constants.go
@@ -61,7 +61,8 @@ const (
 
 	// ECS Client Metrics
 	ecsClientNamespace               = "ECSClient"
-	DiscoverPollEndpointCallName     = ecsClientNamespace + ".DiscoverPollEndpoint"
+	DiscoverPollEndpointFailure      = ecsClientNamespace + ".DiscoverPollEndpointFailure"
+	DiscoverPollEndpointTotal        = ecsClientNamespace + ".DiscoverPollEndpoint"
 	DiscoverPollEndpointDurationName = ecsClientNamespace + ".DiscoverPollEndpointDuration"
 
 	dbClientMetricNamespace                 = "Data"