Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cannonical label for skipping pod identity webhook #216

Merged
merged 2 commits into from
Jun 25, 2024
+5 −0
Merged

feat: cannonical label for skipping pod identity webhook #216

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6bd84d9
feat: cannonical label for skipping pod identity webhook
DerekTBrown Mar 11, 2024
7837954
rename
DerekTBrown Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions deploy/mutatingwebhook.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,11 @@ webhooks:
name: pod-identity-webhook
namespace: default
path: "/mutate"
objectSelector:
matchExpressions:
- key: eks.amazonaws.com/skip-identity-webhook
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with this change, would love to hear @micahhausler opinion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@micahhausler could you take a look at this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prateekgogia Can I have you re-review this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change this to “eks.amazonaws.com/skip-pod-identity-webhook”. Identity webhook may be too generic if EKS adds more identity related webhooks in the future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DanielCKennedy makes sense! Fixed!

operator: "DoesNotExist"
values: []
rules:
- operations: [ "CREATE" ]
apiGroups: [""]
Expand Down
Loading