Refactor annotations parser #239
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modulitos
commented
Sep 13, 2024
| "os" | ||
| "path/filepath" | ||
| "strconv" | ||
| "strings" | ||
| "testing" | ||
|
|
||
| "github.com/aws/amazon-eks-pod-identity-webhook/pkg/cache" | ||
| "github.com/aws/amazon-eks-pod-identity-webhook/pkg/containercredentials" | ||
|
|
||
| corev1 "k8s.io/api/core/v1" | ||
| "sigs.k8s.io/yaml" |
There was a problem hiding this comment.
The changes in this file are just minor refactoring for better readability.
It's easier to view with whitespace diffs disabled:
https://github.com/aws/amazon-eks-pod-identity-webhook/pull/239/files?w=1
modulitos
commented
Sep 13, 2024
| } | ||
| return skippedNames | ||
| } | ||
|
|
There was a problem hiding this comment.
This function has been moved to pkg/annotations/parser.go (with some minor changes)
modulitos
commented
Sep 13, 2024
|
|
||
| return tokenExpiration, containersToSkip | ||
| } | ||
|
|
There was a problem hiding this comment.
This function has been moved to pkg/annotations/parser.go (with some minor changes)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#174
Description of changes:
This is preparatory refactoring, and a non-behavioral change.
There will be a followup PR to add annotations support for the new
service-account-lookup-grace-periodsetting.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.