fetch SAs from apiserver #242
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modulitos
force-pushed
the
notifications-enhancement
branch
2 times, most recently
from
5af4ac8 to
5020bec
Compare
modulitos
force-pushed
the
notifications-enhancement
branch
2 times, most recently
from
ed8a585 to
0178602
Compare
kmala
reviewed
Nov 18, 2024
| } | ||
|
|
||
| go func() { | ||
| for req := range saFetchRequests { |
There was a problem hiding this comment.
This would mean we are making only one request at a time to apiserver right?
There was a problem hiding this comment.
Wrapped this in a goroutine - thanks for the catch 💯
pkg/cache/cache.go
Outdated
| defer cancel() | ||
|
|
||
| klog.V(5).Infof("fetching SA: %s", req.CacheKey()) | ||
| saList, err := getter.ServiceAccounts(req.Namespace).List( |
There was a problem hiding this comment.
why List? why can't we use Get?
There was a problem hiding this comment.
I moved this to Get
modulitos
force-pushed
the
notifications-enhancement
branch
from
a37069c to
ccbb720
Compare
modulitos
force-pushed
the
notifications-enhancement
branch
from
ccbb720 to
1b19f6f
Compare
modulitos
force-pushed
the
notifications-enhancement
branch
from
2c19173 to
9a8d1ad
Compare
modulitos
commented
Dec 2, 2024
| @@ -433,9 +433,10 @@ func (m *Modifier) buildPodPatchConfig(pod *corev1.Pod) *podPatchConfig { | |||
| } | |||
|
|
|||
| // Use the STS WebIdentity method if set | |||
| request := cache.Request{Namespace: pod.Namespace, Name: pod.Spec.ServiceAccountName, RequestNotification: true} | |||
| gracePeriodEnabled := m.saLookupGraceTime > 0 | |||
| request := cache.Request{Namespace: pod.Namespace, Name: pod.Spec.ServiceAccountName, RequestNotification: gracePeriodEnabled} | |||
There was a problem hiding this comment.
I added this change to toggle RequestNotification only when the grace period is enabled.
Previously it was basically a no-op when the feature is disabled and RequestNotification is true, but now we're fetching from the API server when it's true. So we only want it set when the feature is enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#174
Description of changes:
Enhances the implementation introduced in #236 so that we can fetch missing service accounts from the apiserver. Retains the existing guarantees that we won't fetch multiple service accounts concurrently, minimizing load on the apiserver.
This feature is still in shadow mode (off by default).
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.