Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds display static mock for test #261

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Conversation

dingfeli
Copy link
Contributor

Issue #, if available:
When the IDE first starts up, the plugin will try to attach a document listener to the active document, which enables auto triggers.
However, we do not have a similar logic to attach a listener to the part reference which contains the editors. As a result, nothing is attaching document listeners to new documents because the listener that is responsible for doing so is itself not attached.
This PR addresses this problem by introducing similar logic that was used to attach the document listener.

Description of changes:

  • Adds timer exec on display to look for active IPartService to attach part listener.

Test:

  • Open IDE
  • Switch to a file that was not previously opened / focused on
  • Type and observe auto trigger working

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dingfeli dingfeli merged commit 7afa3ec into main Nov 21, 2024
1 check passed
@dingfeli dingfeli deleted the part-listener-eager-attachment branch November 21, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants