Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the image incorrect image version #2522

Closed
wants to merge 1 commit into from
Closed

Conversation

bhargaje
Copy link

What type of PR is this?
bug

Which issue does this PR fix:
The yaml are still pointing to older 1.13.4 instead of 1.14.0

What does this PR do / Why do we need it:
NetworkPolicy support which was launched with VPC CNI 1.14.0 doesn't work because of this incorrect image version of aws-node and aws-init containers.

If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
If you do kubectl apply -f with the existing CNI file you will see aws-node running with both vpc-cni and aws-node but when you create policy and it doesn't have any effect.

Testing done on this change:
Were able to deploy and see network security policy taking effect.

Automation added to e2e:
NA

Will this PR introduce any new dependencies?:
NA

Will this break upgrades or downgrades. Has updating a running cluster been tested?:
NA

Does this change require updates to the CNI daemonset config files to work?:
NA

Does this PR introduce any user-facing change?:
NA


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bhargaje bhargaje requested a review from a team as a code owner August 31, 2023 08:14
@jdn5126
Copy link
Contributor

jdn5126 commented Aug 31, 2023

Thanks for catching this @bhargaje! It looks like the job used for #2517 had some errors. We want to generate these files automatically, so we will take up fixing this

@jdn5126
Copy link
Contributor

jdn5126 commented Aug 31, 2023

Closing in favor of #2525

@jdn5126 jdn5126 closed this Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants