Skip to content

Commit

Permalink
clean up
Browse files Browse the repository at this point in the history
  • Loading branch information
jasonlamz committed Apr 3, 2024
1 parent 5f45648 commit 3a40c14
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 5 deletions.
2 changes: 1 addition & 1 deletion common/lib/plugins/execution_time_plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export class ExecutionTimePlugin extends AbstractConnectionPlugin {
const result = await methodFunc();

const elapsedTimeNanos = getTimeInNanos() - startTime;
logger.debug(Messages.get("ExecutionTimeConnectionPlugin.executionTime", methodName, elapsedTimeNanos.toString()));
logger.debug(Messages.get("ExecutionTimePlugin.executionTime", methodName, elapsedTimeNanos.toString()));
ExecutionTimePlugin.executionTime += elapsedTimeNanos;
return result;
}
Expand Down
2 changes: 1 addition & 1 deletion common/lib/utils/locales/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,5 @@
"ClusterAwareWriterFailoverHandler.standaloneNode": "[TaskB] Host %s is not yet connected to a cluster. The cluster is still being reconfigured.",
"ClusterAwareWriterFailoverHandler.taskBAttemptConnectionToNewWriter": "[TaskB] Trying to connect to a new writer: '%s'",
"ClusterAwareWriterFailoverHandler.alreadyWriter": "Current reader connection is actually a new writer connection.",
"ExecutionTimeConnectionPlugin.executionTime": "Executed %s in %s nanoseconds."
"ExecutionTimePlugin.executionTime": "Executed %s in %s nanoseconds."
}
9 changes: 6 additions & 3 deletions tests/unit/execution_time_plugin.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import { ExecutionTimePlugin } from "aws-wrapper-common-lib/lib/plugins/executio
import { sleep } from "aws-wrapper-common-lib/lib/utils/utils";
import { logger } from "aws-wrapper-common-lib/logutils";
import { Writable } from "stream";
import winston, { } from "winston";
import winston from "winston";

const mockCallable = jest.fn();

Expand All @@ -33,9 +33,9 @@ describe("executionTimePluginTest", () => {

let output = '';
const stream = new Writable();
stream._write = (chunk, encoding, callback) => {
stream._write = (chunk, encoding, next) => {
output = output += chunk.toString();
callback();
next();
};

const streamTransport = new winston.transports.Stream({ stream })
Expand All @@ -48,5 +48,8 @@ describe("executionTimePluginTest", () => {

expect(logMessages[0]).toContain("Executed query in");
expect(ExecutionTimePlugin.getTotalExecutionTime()).toBeGreaterThan(0n);

ExecutionTimePlugin.resetExecutionTime();
expect(ExecutionTimePlugin.getTotalExecutionTime()).toEqual(0n);
})
});

0 comments on commit 3a40c14

Please sign in to comment.