fix: fixing broken link in verify urls #908
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuanLeee
force-pushed
the
fix/verifyLink
branch
4 times, most recently
from
772d5dc to
73ebc7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Verify Urls test is failing because some links are returning a 202 response.
202 should be accepted since it some sites use async processing and retrying multiple times may be rejected because of anti bot measures.
Also invalid AWS pages return a false positive because it only checks that the webpage can be accessed but the actual webpage returned in a 404 page.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.