Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 high level checksums #8955

Merged
merged 8 commits into from
Oct 3, 2024
Merged

Conversation

aemous
Copy link
Contributor

@aemous aemous commented Oct 2, 2024

Issue #, if available:

Low-level aws s3api commands support checksums other than MD5 for verifying end-to-end data integrity. This pull request ports over similar functionality to high-level aws s3 commands.

Description of changes:

  • Added --checksum-algorithm flag for file uploads using aws s3 cp, aws s3 sync, and aws s3 mv.
    • Supported algorithms are CRC32, SHA256, SHA1, CRC32C.
  • Added --checksum-mode flag for file downloads using aws s3 cp, aws s3 sync, and aws s3 mv.
  • Added unit and functional tests to assert the correctness of these changes.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aemous aemous requested review from aws-sdk-python-automation, hssyoo and a team October 2, 2024 14:04
@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 0.08%. Comparing base (f70e1e3) to head (d9d9cdf).
Report is 56 commits behind head on develop.

Files with missing lines Patch % Lines
awscli/customizations/s3/utils.py 0.00% 11 Missing ⚠️
awscli/customizations/s3/subcommands.py 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #8955      +/-   ##
==========================================
- Coverage     0.08%   0.08%   -0.01%     
==========================================
  Files          210     210              
  Lines        16902   16934      +32     
==========================================
  Hits            14      14              
- Misses       16888   16920      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aemous aemous force-pushed the v1-s3-high-level-checksums branch from 9c8cd78 to d9d9cdf Compare October 3, 2024 14:41
@aemous aemous merged commit cb60175 into aws:develop Oct 3, 2024
30 checks passed
aws-sdk-python-automation added a commit that referenced this pull request Oct 4, 2024
* release-1.35.0:
  Bumping version to 1.35.0
  Update changelog based on model updates
  Flexible checksums for S3 high-level commands (#8955)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants