updating customizations/utility #9816
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #9816 +/- ##
===========================================
- Coverage 93.40% 93.33% -0.07%
===========================================
Files 211 209 -2
Lines 17012 16808 -204
===========================================
- Hits 15890 15688 -202
+ Misses 1122 1120 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Thanks for this PR! We'll likely need to remove the forward-compatible test for cn-northwest-2 unless we reintroduce the old string prefix fallback behavior, since aws_partition should handle this but the current partitions datadoes not include that specific test case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes: This PR updates the
get_policy_arn_suffixfunction to dynamically load AWS partition information using botocore'sRuleSetStandardLibaryandpartitions.jsoninstead of hardcoded region mappings.Affected commands:
aws dlm create-default-roleaws emr create-default-rolesaws emr-containers update-role-trust-policyBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.