fix: update the CDK bootstrap template to the latest version #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
96malhar
approved these changes
Nov 15, 2023
ashishdhingra
approved these changes
Nov 15, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #802 +/- ##
=======================================
Coverage 61.46% 61.46%
=======================================
Files 277 277
Lines 10659 10659
Branches 1484 1484
=======================================
Hits 6552 6552
Misses 3566 3566
Partials 541 541 ☔ View full report in Codecov by Sentry. |
ashovlin
reviewed
Nov 15, 2023
| @@ -584,7 +584,7 @@ Resources: | |||
| Type: String | |||
| Name: | |||
| Fn::Sub: /cdk-bootstrap/${Qualifier}/version | |||
| Value: "18" | |||
| Value: "19" | |||
There was a problem hiding this comment.
If 207+208 is from us, did CDK not actually change anything 18 -> 19?
There was a problem hiding this comment.
Yes it's weird. They only updated the version number.
There was a problem hiding this comment.
Hmm, okay. Looks like they're made and then reverted two different changes recently: https://github.com/aws/aws-cdk/commits/main/packages/aws-cdk/lib/api/bootstrap/bootstrap-template.yaml
ashovlin
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.