Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust role used by GitHub action that builds docs. #808

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

ashovlin
Copy link
Member

Issue #, if available: N/A

Description of changes:

  1. Fixes a CI failure on fix: Enable selecting the '.NET 6 on AL2023' platform when deploying to Elastic Beanstalk on Linux #807. We recently adjusted some internal accounts where we run integration tests, so CI_AWS_ROLE_ARN is no longer valid. This reuses the CI_MAIN_TESTING_ACCOUNT_ROLE_ARN instead.
    • The doc generator uses server mode, which requires AWS credentials to pass its health check. I didn't actually see it make any requests when running locally.
  2. Also upgraded the credential action while here, there was a warning about old Node versions.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

with:
role-to-assume: ${{ secrets.CI_AWS_ROLE_ARN }}
Copy link
Member Author

@ashovlin ashovlin Dec 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we tore this down while performing maintenance on the account it maps to. Let me know if you don't think its appropriate to reuse CI_MAIN_TESTING_ACCOUNT_ROLE_ARN for this use case.

@ashovlin ashovlin force-pushed the shovlia/doc-builder-role branch from a8785c3 to 73076dd Compare December 20, 2023 19:16
with:
role-to-assume: ${{ secrets.CI_AWS_ROLE_ARN }}
role-to-assume: ${{ secrets.CI_MAIN_TESTING_ACCOUNT_ROLE_ARN }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think ideally we should use this account to determine which test runner to use, but i'm fine with this for now.

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8990861) 32.34% compared to head (73076dd) 61.44%.
Report is 1 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff             @@
##              dev     #808       +/-   ##
===========================================
+ Coverage   32.34%   61.44%   +29.09%     
===========================================
  Files         271      277        +6     
  Lines       10604    10659       +55     
  Branches     1474     1484       +10     
===========================================
+ Hits         3430     6549     +3119     
+ Misses       6885     3568     -3317     
- Partials      289      542      +253     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashovlin ashovlin merged commit 8a57505 into dev Dec 21, 2023
11 checks passed
@ashovlin ashovlin deleted the shovlia/doc-builder-role branch December 21, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants