feat: Add a "aws-dotnet-deply" tag to ECR repositories that are created during deployment if an existing repository is not provided. #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed during deployment if an existing repository is not provided. This may aid filtering repositories associated with the deploy tool.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #825 +/- ##
==========================================
+ Coverage 61.43% 61.49% +0.06%
==========================================
Files 277 277
Lines 10659 10669 +10
Branches 1484 1486 +2
==========================================
+ Hits 6548 6561 +13
+ Misses 3571 3568 -3
Partials 540 540 ☔ View full report in Codecov by Sentry. |
philasmar
reviewed
May 2, 2024
96malhar
approved these changes
May 3, 2024
philasmar
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A, from internal discussion around #823
Description of changes: Adds the "aws-dotnet-deploy" tag to newly created ECR repositories. This will allow us to clean these up more easily after integration tests and canaries.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.