Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for Web App ARM deployments on ECS Fargate #874

Open
wants to merge 1 commit into
base: feature/arm-support
Choose a base branch
from

Conversation

philasmar
Copy link
Contributor

Issue #, if available:
DOTNET-5124

Description of changes:

  • Updated DeploymentBundleHandler to build X86 and ARM docker images
  • Updated AspNetAppEcsFargate recipe and CDK template to support ARM deployments.
  • Added an integration test to deploy an ARM web app

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@philasmar philasmar requested review from normj and 96malhar October 13, 2024 03:54
Base automatically changed from asmarp/add-supported-architecture-property to feature/arm-support October 14, 2024 16:00
@philasmar philasmar force-pushed the asmarp/ecs-fargate-arm-support branch from 6adaba2 to 268f343 Compare October 14, 2024 16:03
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (feature/arm-support@a94d3e0). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...WS.Deploy.Orchestration/DeploymentBundleHandler.cs 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##             feature/arm-support     #874   +/-   ##
======================================================
  Coverage                       ?   62.80%           
======================================================
  Files                          ?      280           
  Lines                          ?    10951           
  Branches                       ?     1521           
======================================================
  Hits                           ?     6878           
  Misses                         ?     3532           
  Partials                       ?      541           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philasmar philasmar force-pushed the asmarp/ecs-fargate-arm-support branch from 268f343 to 369fb7a Compare October 14, 2024 19:59
@philasmar philasmar force-pushed the asmarp/ecs-fargate-arm-support branch from 369fb7a to 57fbd8c Compare October 14, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants