Fix Beanstalk integ tests #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #886 +/- ##
===========================================
+ Coverage 38.75% 62.81% +24.06%
===========================================
Files 282 282
Lines 10922 10922
Branches 1517 1517
===========================================
+ Hits 4233 6861 +2628
+ Misses 6382 3523 -2859
- Partials 307 538 +231 ☔ View full report in Codecov by Sentry. |
philasmar
approved these changes
Dec 4, 2024
96malhar
approved these changes
Dec 4, 2024
…ions for the Beanstalk environment.
96malhar
force-pushed
the
normj/fix-integ-tests
branch
from
1e0fbde to
77a57ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The beanstalk tests deploying from existing environments are failing because existing environments were being created without permissions to download the deployment bundle from S3. This PR adds the managed beanstalk policy to the role that being created as part of the test.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.