chore: update aws-c-common dependency for CBMC proofs #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
force-pushed
the
update-aws-c-common
branch
2 times, most recently
from
659d548 to
5b6c276
Compare
|
Marking as draft as #772 is required to fix type inconsistencies, and thereafter there will still be further debugging of proofs to make them pass within GitHub's resource constraints. |
tautschnig
force-pushed
the
update-aws-c-common
branch
from
5b6c276 to
d87b774
Compare
tautschnig
force-pushed
the
update-aws-c-common
branch
5 times, most recently
from
6766fcd to
90da32b
Compare
Invoking an external solver is not necessarily cheaper in terms of CPU or memory usage.
CBMC proofs should use the same version of aws-c-common that customers will use in their deployments. Stubs that had since been removed from aws-c-common have now been moved into this repository.
This will avoid type conflicts from silently creeping in.
tautschnig
force-pushed
the
update-aws-c-common
branch
from
90da32b to
d09a070
Compare
tautschnig
force-pushed
the
update-aws-c-common
branch
from
d09a070 to
455984a
Compare
tautschnig
had a problem deploying
to
continuous-integration
GitHub Actions
Failure
tautschnig
had a problem deploying
to
continuous-integration
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
CBMC proofs should use the same version of aws-c-common that customers will use in their deployments. Stubs that had since been removed from aws-c-common have now been moved into this repository.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: