Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue135 (Cannot add key to Encryption Context if already there in default CMM) #185

Closed
wants to merge 8 commits into from

Commits on Aug 6, 2019

  1. Fixed linking issue with algorithm in Sphinx. Black also made some sm…

    …all changes so formatting
    
    may be slightly different, but it should be the same functionality wise.  I have a couple errors
    that I believe are not from my own changes (they were there on master when I pulled and pertain to
    there not being valid AWS credentials for tests for the most part), but they should not be important.
    Adriano Hernandez committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    882dd03 View commit details
    Browse the repository at this point in the history
  2. Went through and fixed all instances where Algorithm was referenced

    instead of AlgorithmSuite.  Changed messages in the docs accordingly.
    Now if you go to RTD you will see everything links together nicely.
    
    What I did not do: change the variable names from "algorithm" to i.e.
    "algorithm_suite".  Mainly because this is a rabbit hole and not immediately
    important I think.  To do it you need to change every single thing that
    calls another thing that calls another thing that has "algorithm" instead
    of "algorithm_suite" and I wanted to keep it simple.
    
    I also found what I think was an incorrect test.  In
    /test/integration/test_i_aws_encryption_sdk_client.py in function
    test_remove_bad_client() there was an assertion error for my tox env tests
    that the dict containing the regional clients was not empty when it should
    have been supposedly.  I believe that it was not meant for it to be empty,
    but for the bad client "us-fakey-12" to be removed, and it was assumed that
    in __init__ for KMSMasterKeyProvider() no regional clients were added, but
    this is false because there is a default added depending on some features
    of the botocore session etc...  So when it was checking to see if it was
    empty it wanted to see that a bad client was added, and then was rightfully
    removed -> back to an empty dict, but if the dict did not start out empty
    the test would fail.  So I made a one line change of this test to make it
    test that specifically the dict did not contain the exact bad client that
    the test was using.
    
    Please get back to me on this final change because you guys know this SDK
    way better than me and I don't want to break anything.  Thanks!
    Adriano Hernandez committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    25e8fd3 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2019

  1. Formatted better to pass linters.

    Adriano Hernandez committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    c62ed68 View commit details
    Browse the repository at this point in the history
  2. Fixed issue aws#135. Took longer than I expected because was trying to

    get the value of the key in the encryption context dictionary to be the
    same (as well as name of the key), but then learned this wasn't what
    we wanted.  Wrote a test that I confirm works only after the change is
    added.
    Adriano Hernandez committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    3256822 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2019

  1. Formatting and lint. Failed the formatting tests on CI, but passed ot…

    …her tests.
    Adriano Hernandez committed Aug 8, 2019
    Configuration menu
    Copy the full SHA
    652b6cf View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2019

  1. Formatting and changed a comment for clarity.

    Adriano Hernandez committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    c523f24 View commit details
    Browse the repository at this point in the history
  2. This should fix formatting issues.

    Adriano Hernandez committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    f31949a View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2019

  1. Merge branch 'master' of github.com:aws/aws-encryption-sdk-python int…

    …o issue135
    Adriano Hernandez committed Aug 15, 2019
    Configuration menu
    Copy the full SHA
    a0a1c20 View commit details
    Browse the repository at this point in the history