Fixed issue #55 #188
Closed
Fixed issue #55 #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 14, 2019 18:33
…ng throwing right type of serializationerror
lizroth
suggested changes
Aug 16, 2019
src/aws_encryption_sdk/internal/formatting/encryption_context.py
Outdated
Show resolved
Hide resolved
src/aws_encryption_sdk/internal/formatting/encryption_context.py
Outdated
Show resolved
Hide resolved
improved readability and future compatibility.
lizroth
suggested changes
Aug 16, 2019
src/aws_encryption_sdk/internal/formatting/encryption_context.py
Outdated
Show resolved
Hide resolved
src/aws_encryption_sdk/internal/formatting/encryption_context.py
Outdated
Show resolved
Hide resolved
src/aws_encryption_sdk/internal/formatting/encryption_context.py
Outdated
Show resolved
Hide resolved
|
Closing stale PR, please reopen as needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #55
Serialization of encryption context will throw the correct type of error. Also broke the serialization function into two using a helper function to improve readability and actually pass flake8 tests (which otherwise fail because of "too complex" which basically means it has too much if/else try/catch logic going on).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable:
No files moved or created, but they were edited. This also contains a merge with Caitlin's PR so it is up to date.