-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add basic benchmarking #275
base: keyring
Are you sure you want to change the base?
Conversation
…ically only mark KMS tests as integ
…ues and remove 1kiB-frame benchmark test
Looks like breaking CI is due to pypa/virtualenv#1857 |
Putting in Draft as this is for keying which has not shipped and is not currently on our roadmap |
You do you, but IMO having benchmarking data in the tests would be useful without keyrings. I'd be happy to take a look at stripping the keyring benchmarks out of this. |
Oh... @mattsb42-aws it appears the mattsb42-aws:benchmarking has been deleted... maybe I can download this source code via |
I have recreated this PR here. |
Whoops; I guess I got a bit overzealous deleting forks when I changed teams. I'll see about dusting off my memory of how I put this together to re-arrange it to use MKPs. |
Description of changes:
This adds some tests that benchmark the performance of the client under different configurations.
Results from running this on an m5a.xlarge EC2 instance:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: