Request response samples #763
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfod
reviewed
Apr 30, 2025
sfod
reviewed
Apr 30, 2025
Comment on lines
+124
to
+126
| // A simple `std::promise<Result>` can be used here. But to support old VS compilers requiring a template parameter | ||
| // be default-constructible, we wrap Result into Optional. | ||
| std::promise<Aws::Crt::Optional<CreateKeysAndCertificateResult>> createKeysResultPromise; |
There was a problem hiding this comment.
We hit here an old VS bug: https://developercommunity.visualstudio.com/t/c-shared-state-futuresstate-default-constructs-the/60897
Alternatively, we could make Result to be default-constructible, but a default value doesn't make much sense for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.