Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding toString method to the S3EventNotification. #302

Closed
wants to merge 2 commits into from
Closed

Adding toString method to the S3EventNotification. #302

wants to merge 2 commits into from

Conversation

msailes
Copy link
Collaborator

@msailes msailes commented Jan 4, 2022

Issue #, if available:
#301

Description of changes:
Added default IntelliJ toString methods for all attributes in all classes. This is quite a nested object so the toString output is quite large. It doesn't contain the S3 object itself though.

Example:

{
   [
      S3EventNotificationRecord{
         "awsRegion=""eu-central-1",
         "eventName=""ObjectCreated:Put",
         "eventSource=""aws:s3",
         "eventTime=1970-01-01T00":"00":00.000Z,
         "eventVersion=""2.0",
         "requestParameters=RequestParametersEntity"{
            "sourceIPAddress=""127.0.0.1"
         },
         "responseElements=ResponseElementsEntity"{
            xAmzId2="EXAMPLE123/5678abcdefghijklambdaisawesome/mnopqrstuvwxyzABCDEFGH",
            "xAmzRequestId=""EXAMPLE123456789"
         },
         s3=S3Entity{
            "configurationId=""testConfigRule",
            bucket=S3BucketEntity{
               "name=""example-bucket",
               "ownerIdentity=UserIdentityEntity"{
                  "principalId=""EXAMPLE"
               },
               "arn=""arn:aws:s3:::example-bucket"
            },
            object=S3ObjectEntity{
               "key=""test/key",
               size=1024,
               "eTag=""0123456789abcdef0123456789abcdef",
               "versionId=""",
               "sequencer=""0A1B2C3D4E5F678901"
            },
            s3SchemaVersion="1.0"
         },
         "userIdentity=UserIdentityEntity"{
            "principalId=""EXAMPLE"
         }
      }
   ]
}

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@carlzogh carlzogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@msailes msailes added the semver-patch Requires a patch semantic versioning bump label Jan 7, 2022
@msailes
Copy link
Collaborator Author

msailes commented May 6, 2022

No longer required, the functionality will existing post v4.

@msailes msailes closed this May 6, 2022
@msailes msailes deleted the s3event-tostring branch August 6, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch Requires a patch semantic versioning bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants