Refactor AWS_LC_FIPS_failure to always exist #2200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… if the library is build in FIPS mode or not
andrewhop
force-pushed
the
fips_failure_cleanup
branch
from
6790e8a to
0270ce7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2200 +/- ##
==========================================
+ Coverage 79.03% 79.04% +0.01%
==========================================
Files 612 612
Lines 106159 106167 +8
Branches 15003 15004 +1
==========================================
+ Hits 83901 83919 +18
+ Misses 21605 21595 -10
Partials 653 653 ☔ View full report in Codecov by Sentry. |
skmcgrail
reviewed
Feb 18, 2025
| fprintf(stderr, "CPU Jitter entropy RNG initialization failed.\n"); | ||
| AWS_LC_FIPS_failure("CPU Jitter failed to initilize"); | ||
| AWS_LC_FIPS_failure("CPU Jitter entropy RNG initialization failed"); |
There was a problem hiding this comment.
This does not change any of the expected output from AWS-LC.
Doesn't this change the output? Or was this an error from the earlier refactor?
There was a problem hiding this comment.
Correct to both:
- The message printing out the error to stderr "CPU Jitter entropy RNG initialization failed" has been there since we added jitter
- In 5553a20#diff-eb881f93cebfbb804479d55b9d097763dbb1d6e85da9d3d9bfbbf2d9cb1db04d I passed this new slightly different message to AWS_LC_FIPS_failure
skmcgrail
approved these changes
Feb 19, 2025
torben-hansen
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change does two things:
Call-outs:
This does not change any of the expected output from AWS-LC.
Testing:
The existing tests that check the FIPS failure messages ensure there is no change in behavior with this change
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.