-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clang format #2211
Draft
andrewhop
wants to merge
11
commits into
aws:main
Choose a base branch
from
andrewhop:clang_format
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Clang format #2211
+25,422
−25,110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5e80dcf
to
dfa9796
Compare
dfa9796
to
4d2404e
Compare
72ecdc9
to
0f1be33
Compare
0e13499
to
5afa0ae
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2211 +/- ##
==========================================
- Coverage 79.05% 78.91% -0.14%
==========================================
Files 612 612
Lines 106218 106052 -166
Branches 15006 15011 +5
==========================================
- Hits 83970 83692 -278
- Misses 21595 21707 +112
Partials 653 653 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR has 3 commits that each do one thing:
Callouts:
Why clang-format-17? Clang 18.1.* had breaking changes between releases and the version in GitHub runners is not the latest 18 release. This is an annoying developer setup because on Mac brew wants to install the latest version which has different opinions on code styling. For now the latest clang-format 17 is easily available in GitHub runners and brew. The actual difference between them is quite small.
https://github.com/actions/runner-images/blob/ubuntu24/20250209.1/images/ubuntu/Ubuntu2404-Readme.md
Testing:
There is a new CI test that ensures no formatting issues are introduced and if we update the .clag-format file they are applied
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.