Skip to content

[DRAFT] BIO datagram functions #2321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Apr 9, 2025

Issues:

Resolves #ISSUE-NUMBER1
Addresses #ISSUE-NUMBER2

Description of changes:

Describe AWS-LC’s current behavior and how your code changes that behavior. If there are no issues this pr is resolving, explain why this change is necessary.

Call-outs:

Point out areas that need special attention or support during the review process. Discuss architecture or design changes.

Testing:

How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link

codecov-commenter commented Apr 9, 2025

Codecov Report

Attention: Patch coverage is 74.27822% with 98 lines in your changes missing coverage. Please review.

Project coverage is 78.75%. Comparing base (b8ab042) to head (b57a265).

Files with missing lines Patch % Lines
crypto/bio/bio_socket_test.cc 70.39% 38 Missing and 15 partials ⚠️
crypto/bio/dgram.c 76.96% 44 Missing ⚠️
crypto/bio/connect.c 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2321      +/-   ##
==========================================
- Coverage   78.76%   78.75%   -0.01%     
==========================================
  Files         620      621       +1     
  Lines      107864   108192     +328     
  Branches    15320    15359      +39     
==========================================
+ Hits        84959    85208     +249     
- Misses      22251    22316      +65     
- Partials      654      668      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@justsmth justsmth force-pushed the BIO-datagram branch 6 times, most recently from 24038b8 to d03a57c Compare April 10, 2025 20:00
@aws aws deleted a comment from github-actions bot Apr 10, 2025
@aws aws deleted a comment from github-actions bot Apr 10, 2025
@aws aws deleted a comment from github-actions bot Apr 10, 2025
@aws aws deleted a comment from github-actions bot Apr 10, 2025
@justsmth justsmth force-pushed the BIO-datagram branch 4 times, most recently from b857e53 to 2a602cd Compare April 11, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants