[kmstool-enclave-cli] Add GenerateRandom command and smoke test scripts #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue aws#131. Signed-off-by: Richard Fan <[email protected]>
Fix incorrect content on genkey command Improve formatting Signed-off-by: Richard Fan <[email protected]>
richardfan1126
changed the title
Signed-off-by: Richard Fan <[email protected]>
richardfan1126
changed the title
|
@petreeftime for your review, thanks |
Signed-off-by: Richard Fan <[email protected]>
richardfan1126
force-pushed
the
kmstool-enclave-cli-add-genrandom
branch
from
d4ea803
to
5bcde49
Compare
petreeftime
approved these changes
Dec 19, 2023
| --aws-access-key-id ${ACCESS_KEY_ID} \ | ||
| --aws-secret-access-key ${SECRET_ACCESS_KEY} \ | ||
| --aws-session-token ${SESSION_TOKEN} \ | ||
| --ciphertext ${CIPHERTEXT} |
There was a problem hiding this comment.
Would be more useful to have a status after each test rather than exit the script after the first failure.
Eg:
Decrypt: SUCCESS
GenKey: FAIL
...
===
Status: FAIL
There was a problem hiding this comment.
Added in 33a67da
Signed-off-by: Richard Fan <[email protected]>
Signed-off-by: Richard Fan <[email protected]>
petreeftime
approved these changes
Dec 21, 2023
leboiko
approved these changes
Jan 8, 2024
agraf
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#131
Description of changes:
genrandomcommand into kmstool-enclave-cliBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.