Skip to content

Commit

Permalink
feat(ci): add build forcing c++ mode
Browse files Browse the repository at this point in the history
Add a distcheck build that sets CFLAGS such that it treats all files as
C++, preventing pull requests from breaking C++ compatibility going
forward.

stack-info: PR: #578, branch: aws-nslick/stack/25
Signed-off-by: Nicholas Sielicki <[email protected]>
  • Loading branch information
aws-nslick committed Sep 5, 2024
1 parent f9f2da4 commit aad2f1b
Showing 1 changed file with 14 additions and 0 deletions.
14 changes: 14 additions & 0 deletions .github/workflows/distcheck.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,9 @@ jobs:
sdk:
- cuda
- neuron
ccmode:
- c
- cpp

include:
- cc-variant: latest
Expand All @@ -109,6 +112,12 @@ jobs:
- cc-variant: latest
cc: gcc
cc-version: 13
- ccmode: cpp
cc-variant: latest
cc: clang
sdk: cuda
tracing: none
cc-version: 19

name: u2204/${{ matrix.sdk }}/libfabric@git/${{matrix.cc}}(${{matrix.cc-variant}})/distcheck/
steps:
Expand Down Expand Up @@ -188,6 +197,11 @@ jobs:
export CC="${{ matrix.realcc || matrix.cc }}"
if [ "${{ matrix.ccmode }}" == "cpp" ]; then
export CC="${CC/clang/clang++}"
export CC="${CC/gcc/g++}"
fi
# actions/checkout@v4 would drop the plugin source in $PWD,
# so go ahead and build it.
./autogen.sh
Expand Down

0 comments on commit aad2f1b

Please sign in to comment.