Skip to content

Commit

Permalink
fix(neuron): remove const from ncclNetPlugin_v4 sym
Browse files Browse the repository at this point in the history
const variables have internal linkage by default under c++; nvidia
interface requires it not be const because its modified during init.
Remove const for neuron, too.

stack-info: PR: #577, branch: aws-nslick/stack/24
Signed-off-by: Nicholas Sielicki <[email protected]>
  • Loading branch information
aws-nslick committed Sep 4, 2024
1 parent 31e7acf commit eb0e05e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/nccl_ofi_interface_neuron.c
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ static ncclResult_t getProperties_v4(int dev_id, ncclNetProperties_v4_t *props)
return ncclSuccess;
}

NCCL_OFI_EXPORT_SYMBOL const ncclNet_v4_t ncclNetPlugin_v4 = {
NCCL_OFI_EXPORT_SYMBOL ncclNet_v4_t ncclNetPlugin_v4 = {
.name = "AWS Libfabric",
.init = init_v4,
.devices = nccl_net_ofi_devices,
Expand Down

0 comments on commit eb0e05e

Please sign in to comment.