Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add srpm generation #526

Closed
wants to merge 1 commit into from
Closed

ci: add srpm generation #526

wants to merge 1 commit into from

Conversation

aws-nslick
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@aws-nslick aws-nslick requested review from rajachan and a team as code owners August 15, 2024 16:25
@a-szegel
Copy link
Contributor

bot:aws:retest ... was messing with Jenkins during this PR's build and it disrupted it.

@aws-nslick
Copy link
Contributor Author

apologies for the noise, minor differences between act and the actual gh hosted runners. Should be good now.

GIT_VERSION Outdated Show resolved Hide resolved
dist/libnccl-net-ofi.spec Outdated Show resolved Hide resolved
dist/libnccl-net-ofi.spec Outdated Show resolved Hide resolved
dist/libnccl-net-ofi.spec Outdated Show resolved Hide resolved
configure.ac Outdated Show resolved Hide resolved
dist/PKGBUILD Outdated Show resolved Hide resolved
.github/workflows/srpm.yaml Show resolved Hide resolved
configure.ac Outdated Show resolved Hide resolved
dist/PKGBUILD Outdated Show resolved Hide resolved
dist/libnccl-net-ofi.spec Outdated Show resolved Hide resolved
dist/libnccl-net-ofi.spec Outdated Show resolved Hide resolved
@a-szegel
Copy link
Contributor

bot:aws:retest ... infra issue, trying again

Makefile.am Show resolved Hide resolved
@aws-nslick
Copy link
Contributor Author

bot:aws:retest

@a-szegel
Copy link
Contributor

bot:aws:retest ... issue in CI

@aws-nslick
Copy link
Contributor Author

Change rejected by @bwbarrett

@aws-nslick aws-nslick closed this Aug 24, 2024
@aws-nslick aws-nslick reopened this Aug 28, 2024
Comment on lines +34 to +37
%if "%{_vendor}" == "debbuild"
Group: devel
%else
Group: Development/Tools%{?suse_version:/Building}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debbuild covers all the non-suse cases?

%configure \
--prefix="%{_prefix}" \
--disable-tests \
--with-mpi=no \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disable-tests should already be disabling mpi

@aws-nslick
Copy link
Contributor Author

This has been melded into #542

@aws-nslick aws-nslick closed this Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants