[Accounting] Fix issues that were breaking the rendering of accounting info #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g info. In particular: 1. fix the retrieval of compute nodes instance type to determine price estimate; 2. fix the generation of job properties rendered in the job accounting modal.
gmarciani
force-pushed
the
wip/mgiacomo/2024070/fix-acct-0711-1
branch
from
b8a4830
to
cba20d8
Compare
hanwen-pcluste
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes
Fix issues that were breaking the rendering of accounting info
In particular:
Also minor improvements to log lines related to accounting.
How Has This Been Tested?
Manually deployed and verified that the modal showed the accounting info per job is displayed.
In order to increase the likelihood of your contribution being accepted, please make sure you have read both the Contributing Guidelines and the Project Guidelines
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.