Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dependencies] Add version constraint ws>=8.17.1 to address vulnerability #344

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

gmarciani
Copy link
Collaborator

@gmarciani gmarciani commented Jul 23, 2024

Changes

Add version constraint ws>=8.17.1 to address vulnerability https://github.com/aws/aws-parallelcluster-ui/security/dependabot/41.

Note this PR contains the commits from #343 that are out of scope but worth it to test together. These commits will be removed from this Pr once the other one will be merged.

How Has This Been Tested?

  1. PCUI deployed in personal environment
  2. Verified login/logout works
  3. Verified cluster listing works
  4. Verified unit tests work

References

PR Quality Checklist

  • I added tests to new or existing code
  • I removed hardcoded strings and used react-i18next library (useTranslation hook and/or Trans component), see an example here
  • I made sure no sensitive info gets logged at any time in the codebase (see here) (e.g. no user info or details, no stacktraces, etc.)
  • I made sure that any GitHub issue solved by this PR is correctly linked
  • I checked that infrastructure/update_infrastructure.sh runs without any error
  • I checked that npm run build builds without any error
  • I checked that clusters are listed correctly
  • I checked that a new cluster can be created (config is produced and dry run passes)
  • I checked that login and logout work as expected

In order to increase the likelihood of your contribution being accepted, please make sure you have read both the Contributing Guidelines and the Project Guidelines

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@gmarciani gmarciani added dependencies Pull requests that update a dependency file release:improvement Security labels Jul 23, 2024
@gmarciani gmarciani merged commit 289862a into aws:main Jul 23, 2024
2 checks passed
@gmarciani gmarciani deleted the wip/mgiacomo/fix-ws-vulns-0723-1 branch July 23, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file release:improvement Security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants