Skip to content

Conversation

hehe7318
Copy link
Contributor

@hehe7318 hehe7318 commented Sep 16, 2025

Description

  • Support PCUI in us-gov-east-1(OSU) region and other future GovCloud regions

Changes

  • Modify the condition check InGovCloud checking the Partition equal to aws-us-gov rather than check region equal to us-gov-west-1

Tests

Manually test done. PCUI in gov-east (OSU) DID deploy successful, and it works well. Below is what we did:

  1. Deploy stack using the modified parallelcluster-ui-cognito.yaml, specify the user email, create stack.
  2. Get the output value of the cognito stack in cfn console, there should be UserPoolId, UserPoolAuthDomain and SNSRole
  3. Deploy stack using the modified parallelcluster-ui.yaml, specify the PCluster version and fill in the External Cognito Stack Section using the output value from Step 2. Create the stack.

PR Quality Checklist

  • I added tests to new or existing code
  • I removed hardcoded strings and used react-i18next library (useTranslation hook and/or Trans component), see an example here
  • I made sure no sensitive info gets logged at any time in the codebase (see here) (e.g. no user info or details, no stacktraces, etc.)
  • I made sure that any GitHub issue solved by this PR is correctly linked
  • I checked that infrastructure/update_infrastructure.sh runs without any error
  • I checked that npm run build builds without any error
  • I checked that clusters are listed correctly
  • I checked that a new cluster can be created (config is produced and dry run passes)
  • I checked that login and logout work as expected

In order to increase the likelihood of your contribution being accepted, please make sure you have read both the Contributing Guidelines and the Project Guidelines

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@gmarciani
Copy link
Collaborator

Changes LGTM, but how have them been tested?

@hehe7318
Copy link
Contributor Author

Changes LGTM, but how have them been tested?

SA is testing it, I will let you know the result.

@hehe7318 hehe7318 force-pushed the wip/support-us-gov-east-1 branch from 15472c9 to 149c6f4 Compare September 18, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants