Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update build command to use yarn #1162

Merged
merged 1 commit into from
Dec 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,9 @@ The developers actively use Linux for development, but macOS and the Windows Sub

```bash
# From the root directory of this repository
./build.sh
yarn build

# Once you've run ./build.sh from the root directory at least once, then
# Once you've run "yarn build" from the root directory at least once, then
# you can do subsequent build & test iterations from the RFDK package directory to save time.
cd packages/aws-rfdk
yarn build+test
Expand Down Expand Up @@ -155,7 +155,7 @@ yarn clean
./clean.sh

# Rebuild
./build.sh
yarn build
```

If that does not work, then you might try the following nuclear option. **WARNING** -- this will
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ These instructions assume that your working directory is `examples/deadline/All-
```bash
# Navigate to the root directory of the RFDK repository
pushd ../../../..
./build.sh
yarn build
# Enter the Docker container to run the pack scripts
./scripts/rfdk_build_environment.sh
./pack.sh
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ These instructions assume that your working directory is `examples/deadline/All-
```bash
# Navigate to the root directory of the RFDK repository (assumes you started in the example's directory)
pushd ../../../..
./build.sh
yarn build
# Navigate back to the example directory
popd
# Run the example's build
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ These instructions assume that your working directory is `examples/deadline/All-
```bash
# Navigate to the root directory of the RFDK repository
pushd ../../../..
./build.sh
yarn build
# Enter the Docker container to run thepack scripts
./scripts/rfdk_build_environment.sh
./pack.sh
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ These instructions assume that your working directory is `examples/deadline/All-
```bash
# Navigate to the root directory of the RFDK repository (assumes you started in the example's directory)
pushd ../../../..
./build.sh
yarn build
# Navigate back to the example directory
popd
# Run the example's build
Expand Down
2 changes: 1 addition & 1 deletion examples/deadline/EC2-Image-Builder/python/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ These instructions assume that your working directory is `examples/deadline/EC2-
```bash
# Navigate to the root directory of the RFDK repository
pushd ../../../..
./build.sh
yarn build
# Enter the Docker container to run the pack scripts
./scripts/rfdk_build_environment.sh
./pack.sh
Expand Down
2 changes: 1 addition & 1 deletion examples/deadline/EC2-Image-Builder/ts/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ These instructions assume that your working directory is `examples/deadline/EC2-
```bash
# Navigate to the root directory of the RFDK repository (assumes you started in the example's directory)
pushd ../../../..
./build.sh
yarn build
# Navigate back to the example directory
popd
# Run the example's build
Expand Down
2 changes: 1 addition & 1 deletion examples/deadline/Local-Zone/python/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ These instructions assume that your working directory is `examples/deadline/Loca
```bash
# Navigate to the root directory of the RFDK repository
pushd ../../../..
./build.sh
yarn build
# Enter the Docker container to run the build and pack scripts
./scripts/rfdk_build_environment.sh
./pack.sh
Expand Down
2 changes: 1 addition & 1 deletion examples/deadline/Local-Zone/ts/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ These instructions assume that your working directory is `examples/deadline/Loca
```bash
# Navigate to the root directory of the RFDK repository (assumes you started in the example's directory)
pushd ../../../..
./build.sh
yarn build
# Navigate back to the example directory
popd
# Run the example's build
Expand Down
2 changes: 1 addition & 1 deletion integ/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

To run all test suites:

1. Build and install dependencies by running build.sh from the top-level RFDK directory
1. Build and install dependencies by running `yarn build` from the top-level RFDK directory
1. Configure AWS credentials. There are a few options for this:
* Configure credentials [using environment variables](https://docs.aws.amazon.com/sdk-for-javascript/v2/developer-guide/loading-node-credentials-environment.html)
* Run the integration tests on an [EC2 Instance with an IAM role](https://docs.aws.amazon.com/sdk-for-javascript/v2/developer-guide/loading-node-credentials-iam.html)
Expand Down
2 changes: 1 addition & 1 deletion scripts/prep_release.sh
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ PULL_AL_FROM_ECR_ARGS=(
/bin/bash ${SCRIPT_DIR}/pull_amazonlinux_from_ecr.sh "${PULL_AL_FROM_ECR_ARGS[@]}"

# Run integ tests
/bin/bash ${ROOT_DIR}/build.sh
(cd "${ROOT_DIR}" && yarn run build)
pushd $TESTS_DIR
yarn run e2e-automated
popd
Expand Down