test: add test_marker checks to integ scripts #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Caden Marofke <[email protected]>
ddneilson
approved these changes
Dec 21, 2023
edwards-aws
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I added a 'test_marker' sentinel file to our integration component directories, but missed updating a few other scripts that expected the old
cdk.jsonfile, causing unexpected behviour with tests. I've updated all of the scripts in theintegdirectory.Testing
Ran the cleanup script, confirming it cleaned up each component directory with a
test_markerfile in it.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license