Set BAD_REQUEST error code for 400 error instead of UNKNOWN #2062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcmoritz
commented
Aug 29, 2022
| @@ -73,6 +73,8 @@ static CoreErrors GuessBodylessErrorType(Aws::Http::HttpResponseCode responseCod | |||
| return CoreErrors::ACCESS_DENIED; | |||
| case HttpResponseCode::NOT_FOUND: | |||
| return CoreErrors::RESOURCE_NOT_FOUND; | |||
| case HttpResponseCode::BAD_REQUEST: | |||
There was a problem hiding this comment.
This is the main change of this PR, everything else is plumbing to make the BAD_REQUEST error code available in every error class.
|
This PR is part of trying to improve the error messages (to the same standard as boto3) that are raised from Apache Arrow when interacting with S3: https://issues.apache.org/jira/browse/ARROW-17079 |
jmklix
added
the
needs-review
jmklix
removed
the
needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
This fixes #1843
More crucially, it removes the current inconsistency between boto3 and the AWS CLI on the one hand and the C++ SDK on the other hand when it comes to 400 return codes.
Description of changes:
Convert a 400 http status code into a
BAD_REQUESTerror instead ofUNKNOWN.This PR might need to be re-done from the Amazon side since I'm not familiar with the code generation tools used. I just fixed the occurrences manually.
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.