Fix smithy client retry handling #3160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbiscigl
force-pushed
the
smithy/fix_retry_logic
branch
from
dcaed4c to
9204992
Compare
DmitriyMusatkin
approved these changes
Oct 23, 2024
SergeyRyabinin
commented
Oct 23, 2024
| pRequestCtx->m_endpoint.GetAttributes()->authScheme.GetSigningRegion().value() : ""; | ||
| const Aws::String signerRegion = [&]() { | ||
| if (!regionFromResponse.empty() && | ||
| pRequestCtx->m_endpoint.GetAttributes() && |
There was a problem hiding this comment.
the problem here was that lack of the check for an Optional pRequestCtx->m_endpoint.GetAttributes()
which is not always set.
SergeyRyabinin
commented
Oct 23, 2024
| AWS_LOGSTREAM_DEBUG(AWS_SMITHY_CLIENT_LOG, "Request returned error. Attempting to generate appropriate error codes from response"); | ||
| assert(m_errorMarshaller); | ||
| auto error = m_errorMarshaller->BuildAWSError(httpResponse); | ||
| return HttpResponseOutcome(std::move(error)); |
There was a problem hiding this comment.
the main diff here is to not perform early return
return pRequestCtx->m_responseHandler(HttpResponseOutcome(std::move(error)));
but I also used IIFE to avoid modification of the other blocks by keeping the original variable Aws::Client::HttpResponseOutcome outcome
sbiscigl
force-pushed
the
smithy/fix_retry_logic
branch
from
9204992 to
8be9734
Compare
SergeyRyabinin
force-pushed
the
smithy/fix_retry_logic
branch
from
8be9734 to
9310e6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
The retry handling was broken on the smithy request pipeline
Description of changes:
Do no immediately call the response handler in case of error, go through retry loop first
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.