Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending jmespath expressions #3163

Merged
merged 10 commits into from
Nov 4, 2024
Merged

Extending jmespath expressions #3163

merged 10 commits into from
Nov 4, 2024

Conversation

sbera87
Copy link
Contributor

@sbera87 sbera87 commented Oct 30, 2024

Issue #, if available:

Description of changes:

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sbera87 sbera87 changed the title Extending jmespath expressions [Work in progress] Extending jmespath expressions Nov 3, 2024
@sbera87
Copy link
Contributor Author

sbera87 commented Nov 3, 2024

 "operationContextParams":{
        "ResourceArnList":{"path":"TransactItems[*].[ConditionCheck.TableName, Put.TableName, Delete.TableName, Update.TableName][]"}

will generate the following code:

//Accessor for dynamic context endpoint params
Aws::Vector<Aws::String> TransactWriteItemsRequest::GetOperationContextParams() const{
  Aws::Vector<Aws::String> result;
  auto& TransactItemsElem = (*this).GetTransactItems();
  for (auto& TransactItemsElem : TransactItemsElem)
  {
  	auto& ConditionCheckElem = TransactItemsElem.GetConditionCheck().GetTableName();
  	result.emplace_back(ConditionCheckElem);
  	auto& PutElem = TransactItemsElem.GetPut().GetTableName();
  	result.emplace_back(PutElem);
  	auto& DeleteElem = TransactItemsElem.GetDelete().GetTableName();
  	result.emplace_back(DeleteElem);
  	auto& UpdateElem = TransactItemsElem.GetUpdate().GetTableName();
  	result.emplace_back(UpdateElem);
  }
  return result;
}

if (!this.getVarName().peek().right) {
this.getVarName().pop();
} else {
break;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would rather have this handled in the loop than a break statement

while (!this.getVarName().isEmpty() && !this.getVarName().peek().right) {
  this.getVarName().pop();
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall change

@sbera87 sbera87 requested a review from sbiscigl November 4, 2024 18:20
@sbera87 sbera87 merged commit 687dc45 into main Nov 4, 2024
4 of 5 checks passed
@sbera87 sbera87 deleted the jmes branch November 25, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants