add missing http verbs in http spec #3207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeyRyabinin
approved these changes
Nov 27, 2024
sbera87
reviewed
Nov 27, 2024
| */ | ||
| AWS_CORE_API const char* GetNameForHttpMethod(HttpMethod httpMethod); | ||
| } // namespace HttpMethodMapper | ||
| enum class HttpMethod { |
There was a problem hiding this comment.
This looks good. Food for thought: Maybe in future, we can introduce a wrapped enum macro which can not only generate the enum class but also have a toString method for the concerned enum class. Then we can get the enum string and do contextual parsing as needed.
sbera87
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds missing verbs from the http spec specifically
CONNECT,OPTIONS, andTRACECheck all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.