Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve credentials on retry for S3Express #5638

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

davidh44
Copy link
Contributor

@davidh44 davidh44 commented Oct 2, 2024

Motivation and Context

Re-resolve credentials on retries for S3Express. Tokens have short lifespan (5 min) and can become stale while queued up. Currently, credentials are not re-resolved on retries

Modifications

Save IdentityProvider and ResolveIdentityRequest in S3AuthSchemeInterceptor , retrieve and resolve identity for S3Express retries in retry stage

Testing

Added functional tests and updated codegenerated test classes

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@davidh44 davidh44 requested a review from a team as a code owner October 2, 2024 21:27
Copy link

sonarcloud bot commented Oct 3, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant