Add tests to verify legacy signer code path #6473
Conversation
| @@ -274,6 +274,12 @@ | |||
| <version>${awsjavasdk.version}</version> | |||
| <scope>test</scope> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>software.amazon.awssdk</groupId> | |||
| <artifactId>http-auth-aws-crt</artifactId> | |||
There was a problem hiding this comment.
Added CRT dependency to be able to run sigV4a tests (otherwise it'd throw CRT not available error). There is a module to test functionalities w/o CRT https://github.com/aws/aws-sdk-java-v2/tree/master/test/crt-unavailable-tests
|
|
||
| assertThatThrownBy(() -> client.multiAuthWithOnlySigv4a(r -> r.stringMember(""))) | ||
| .hasMessageContaining(CRT_DEPENDENCY_ERROR_MESSAGE); | ||
| .hasMessageContaining("dependency not available"); |
There was a problem hiding this comment.
CRT specific error is covered in https://github.com/aws/aws-sdk-java-v2/blob/master/test/crt-unavailable-tests/src/test/java/software/amazon/awssdk/auth/aws/AwsV4aAuthSchemeTest.java. Updated this test to verify resolution behavior
|
|
||
| assertThatThrownBy(() -> client.simpleOperationWithNoEndpointParams(r -> r.stringMember(""))) | ||
| .hasMessageContaining(CRT_DEPENDENCY_ERROR_MESSAGE); | ||
| .hasMessageContaining("dependency not available"); |
There was a problem hiding this comment.
Same here. CRT specific error is covered in https://github.com/aws/aws-sdk-java-v2/blob/master/test/crt-unavailable-tests/src/test/java/software/amazon/awssdk/auth/aws/AwsV4aAuthSchemeTest.java. Updated this test to verify resolution behavior
| } | ||
|
|
||
| @Test | ||
| public void asyncClient_signerOverriddenInConfig_takesPrecedence() { |
There was a problem hiding this comment.
super nit: some tests have public others don't
|
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
2 participants
Add tests to verify that signer properties are propagated to legacy signers